[C/C++] Simple Password Generator

change while (i==1) to while (i!=0)

or change

cout << "Again? (0 to quit)"; to cout << "Again? (1 to do it again)";

here is mine:

Code:

#include <iostream>
#include <string>
#include <cstdlib>
#include <time.h>


using namespace std;

int generate(int len);
void main(void)
{
	int exit;
	int length;
	while(true){
		cout << "How many chars?\n";
		cin >> length;
		generate(length);
		cout<<"\n\nExit?\n1=yes\n2=no\n";
		cin>>exit;
		cout<<"\b";
		if (exit==1){
			break;
		}
	}
}

int generate(int len){
	string poss="abcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";
	int rand_num;
	srand(time(NULL));
	string pass;
	for (int x=1;x<=len;x++){
		
		rand_num=rand() % 62;
		pass+=poss.at(rand_num);
	}
	cout<<"password: "<<pass<<endl;
	return 0;
}

okay it might not be easyer but i made it this way and im going to make a windows form out of this

I have a question, 2 infact.. Im learning C and C++ and is a string supposed to be a character array? Or is there a string datatype?

Should it not be char poss[65]={"bcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKL MNOPQRSTUVWXYZ"};

Please correct me if I am wrong..

And also, is exit not a reserved keyword? So it cant be used as a variable name??

String is sort of like a C++ version of a character array(to make things easier I guess), probably made because C++ is more OO then C and this would be an easy way to demonstrate it

And yep, exit is a reserved keyword

srry if there's mistakes in the code. I wrote these sources long ago but never compiled it

i was referring to the code written by iopop9

string may be the C++ implementation of a character array, but character arrays still seem to be better. i.e. I couldn't use cin.getline(); with a string, I had to use a character array.(THANKS WHY!)

Nicely done guys . I guess this is just a snippet but otherwise you should write the pass to a file, hard to copy the pass from the console

Oh and just a question iopop9 why do you have cstdlib and string included?
They are not needed for that app, just makes the exe larger

OFF TOPIC: I'm a noob, I read this, and I figured i'd throw random information in here. I JUST learned this today. xD

Ever see a source code including this line?
[php]#define WIN32_LEAN_AND_MEAN[/php]

I had seen that quite a few times before, and I always wondered what it was. It just looks like such an obscure line of code. But here it is.

It is used to reduce the size of files that use the windows.h header. It excludes some of the less used/more advanced features of the header file. It also speeds up compile time (in large files that make multiple uses of the windows header.) as well as run time, but again, only in larger files. Because compiling 50 lines of code doesn't take too long anyway. =/


While i'm at it, i'll add MSDN's piece on reducing build time with smaller header files.

I did not know that, thanks for the info!
Should make my apps even more tiny... I learned the hard way that using things as printf/fopen is a lot better than having to deal with string/fstream libs that likes to make the output a lot larger. Funny enough my n00b teacher in C++ at school never talked anything about things like that during a whole 3 years of study, I should probably mentioned that he never got us any longer than making console apps as well...

Yep it works like a charm.